Repository navigation
Pass host import arguments with their WebAssembly types - #18
Merged
FlorianRappl merged 3 commits intoNov 9, 2026
Merged
Conversation
The switch expression in ConvertArguments had int, long, float and double arms, so C# gave it the common type double: every argument reached the import callback as a boxed double, and i64 values above 2^53 lost precision. Box each arm as object instead, so i32, i64, f32 and f64 arrive as int, long, float and double.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Host import callbacks received every argument as a boxed
double. The switch expression inConvertArgumentshasint,long,floatanddoublearms, so C# gives it the common typedouble. Ani64above 2^53 therefore lost precision, and(int)arguments[0]threwInvalidCastException.object, soi32,i64,f32andf64arrive asint,long,floatanddouble.doublefor a non-f64parameter need to cast to the real type;Convert.ToXxxkeeps working.Added a test that passes all four types through an import (including 2^53 + 1); it fails before the change and passes after.
🤖 Generated with Claude Code